[commit/ada+testsuite] print ada boolean expression results as true/false

Joel Brobecker brobecker@adacore.com
Fri Dec 28 13:10:00 GMT 2007


Hi Mark!

Thanks for taking a look at the patch, this is always much appreciated.

> > +      *pos -= 1;
> > +      return value_cast (LA_BOOL_TYPE, 
> > +			 evaluate_subexp_standard (expect_type, exp,
> > +						   pos, noside));
> 
> I think the fact that you need three lines here means that it makes
> more sense to avoid the nested function calls and use a (temporary)
> variable instead.

Sure, that's a good idea. Fixed with the attached patch:

2007-12-28  Joel Brobecker  <brobecker@adacore.com>

        * ada-lang.c (ada_evaluate_subexp): Break two large expressions
        using temporary variables.

Tested on x86-linux, no regression. Checked in.

-- 
Joel



More information about the Gdb-patches mailing list