RFA: Use gdb_get_line_number in asm-source.exp

Joel Brobecker brobecker@adacore.com
Sat Dec 22 06:39:00 GMT 2007


Hi Jim,

> 2007-12-21  Jim Blandy  <jimb@codesourcery.com>
> 
> 	* gdb.asm/asm-source.exp: Use gdb_get_line_number, instead of
> 	hard-coding source line numbers into the test.
> 	* gdb.asm/asmsrc1.s, gdb.asm/asmsrc2.s: Add comments for
> 	gdb_get_line_number to find.

FWIW, this looks good to me. There is just ...

>  	comment "Call a subroutine in another file."
>  
> +        comment "mark: call foo2"
>  	gdbasm_call foo2

The indenting here that looks a bit strange.

-- 
Joel



More information about the Gdb-patches mailing list