[PATCH] Fix DW_CFA_restore_extended parsing

Jim Blandy jimb@red-bean.com
Fri Dec 21 19:16:00 GMT 2007


On Dec 21, 2007 5:59 AM, Luis Machado <luisgpm@linux.vnet.ibm.com> wrote:
> On Thu, 2007-12-20 at 14:03 -0800, Jim Blandy wrote:
> > The only difference between those two opcodes is in their encoding ---
> > the action to be performed is identical.  It seems silly to duplicate
> > the code.  Could you pull the common code out into its own function,
> > and then have both cases simply parse their arguments and call the
> > function?
>
> Like so?

Yes --- looks great.  Please commit.  Thanks!



More information about the Gdb-patches mailing list