[commit] remove opaque enum declaration in symtab.h

Joel Brobecker brobecker@adacore.com
Thu Dec 20 05:52:00 GMT 2007


> > > > 2007-12-19  Joel Brobecker  <brobecker@adacore.com>
> > > > 
> > > >         * symtab.h: #include "defs.h".
> > > 
> > > FYI, this is not necessary; defs.h is always included first and
> > > everything depends on it.
> > 
> > Should I remove it, then? We have other .h files that include defs.h,
> > perhaps we should take care of them too...
> 
> Yes please.

Fixed with the attached patch.

2007-12-20  Joel Brobecker  <brobecker@adacore.com>

        * symtab.h: Remove "defs.h" #include.
        * Makefile.in (symtab_h): Update dependencies.

Thanks for the feedback.  I will send a patch for the remaining
unexpected includes.

-- 
Joel
-------------- next part --------------
Index: symtab.h
===================================================================
RCS file: /cvs/src/src/gdb/symtab.h,v
retrieving revision 1.109
diff -u -p -r1.109 symtab.h
--- symtab.h	19 Dec 2007 13:21:32 -0000	1.109
+++ symtab.h	20 Dec 2007 05:31:31 -0000
@@ -22,8 +22,6 @@
 #if !defined (SYMTAB_H)
 #define SYMTAB_H 1
 
-#include "defs.h"
-
 /* Opaque declarations.  */
 struct ui_file;
 struct frame_info;
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.967
diff -u -p -r1.967 Makefile.in
--- Makefile.in	19 Dec 2007 13:21:32 -0000	1.967
+++ Makefile.in	20 Dec 2007 05:31:48 -0000
@@ -885,7 +885,7 @@ srec_h = srec.h
 stabsread_h = stabsread.h
 stack_h = stack.h
 symfile_h = symfile.h $(symtab_h)
-symtab_h = symtab.h $(defs_h)
+symtab_h = symtab.h
 target_h = target.h $(bfd_h) $(symtab_h) $(dcache_h) $(memattr_h) $(vec_h)
 target_descriptions_h = target-descriptions.h
 terminal_h = terminal.h


More information about the Gdb-patches mailing list