[commit] Delete language.h:op_error declaration

Joel Brobecker brobecker@adacore.com
Wed Dec 19 13:26:00 GMT 2007


  Re: http://www.sourceware.org/ml/gdb-patches/2007-12/msg00270.html
  (Re: [commit] language.h minor cleanup)

There was a problem with an enum which was used before being defined.
As it turns out, there is only one function declaration that uses this
enum (op_error), and this function was deleted in Aug 2003.

So I deleted the declaration, which allowed us to get rid of the
dependency on the enum as well.

2007-12-19  Joel Brobecker  <brobecker@adacore.com>

        * language.h (enum exp_opcode): Remove commented out forward
        (op_error): Delete declaration.

Tested on x86-linux by rebuilding GDB, and checked in.

-------------- next part --------------
Index: language.h
RCS file: /cvs/src/src/gdb/language.h,v
retrieving revision 1.45
diff -u -p -r1.45 language.h
--- language.h	17 Dec 2007 14:06:34 -0000	1.45
+++ language.h	19 Dec 2007 12:46:01 -0000
@@ -31,8 +31,6 @@ struct frame_info;
 struct expression;
 struct ui_file;
-/* enum exp_opcode;     ANSI's `wisdom' didn't include forward enum decls. */
 /* This used to be included to configure GDB for one or more specific
    languages.  Now it is left out to configure for all of them.  FIXME.  */
 /* #include "lang_def.h" */
@@ -410,9 +408,6 @@ extern void binop_type_check (struct val
 /* Error messages */
-extern void op_error (const char *lhs, enum exp_opcode,
-		      const char *rhs);
 extern void type_error (const char *, ...) ATTR_FORMAT (printf, 1, 2);
 extern void range_error (const char *, ...) ATTR_FORMAT (printf, 1, 2);

More information about the Gdb-patches mailing list