[commit] remove commented out code in mi/mi-main.c

Joel Brobecker brobecker@adacore.com
Sun Dec 16 14:00:00 GMT 2007


Hello,

I finally deleted some code that was commented out in 1999.
I think that the idea implemented by this function is OBE thanks
to varobjs.

2007-12-16  Joel Brobecker  <brobecker@adacore.com>

        * mi/mi-main.c: Remove code that was commented out in 1999.

Tested by rebuilding GDB on x86-linux.
Checked in.

-- 
Joel
-------------- next part --------------
Index: mi/mi-main.c
===================================================================
RCS file: /cvs/src/src/gdb/mi/mi-main.c,v
retrieving revision 1.105
diff -u -p -r1.105 mi-main.c
--- mi/mi-main.c	16 Oct 2007 11:55:17 -0000	1.105
+++ mi/mi-main.c	16 Dec 2007 13:34:28 -0000
@@ -643,36 +643,6 @@ mi_cmd_data_write_register_values (char 
   return MI_CMD_DONE;
 }
 
-#if 0
-/* This is commented out because we decided it was not useful.  I leave
-   it, just in case.  ezannoni:1999-12-08 */
-
-/* Assign a value to a variable.  The expression argument must be in
-   the form A=2 or "A = 2" i.e. if there are spaces it needs to be
-   quoted.  */
-enum mi_cmd_result
-mi_cmd_data_assign (char *command, char **argv, int argc)
-{
-  struct expression *expr;
-  struct cleanup *old_chain;
-
-  if (argc != 1)
-    {
-      mi_error_message = xstrprintf ("mi_cmd_data_assign: Usage: -data-assign expression");
-      return MI_CMD_ERROR;
-    }
-
-  /* NOTE what follows is a clone of set_command().  FIXME: ezannoni
-     01-12-1999: Need to decide what to do with this for libgdb purposes.  */
-
-  expr = parse_expression (argv[0]);
-  old_chain = make_cleanup (free_current_contents, &expr);
-  evaluate_expression (expr);
-  do_cleanups (old_chain);
-  return MI_CMD_DONE;
-}
-#endif
-
 /* Evaluate the value of the argument.  The argument is an
    expression. If the expression contains spaces it needs to be
    included in double quotes.  */


More information about the Gdb-patches mailing list