[RFA] patch for 2384, dangling TYPE_VPTR_BASETYPE

Doug Evans dje@google.com
Sat Dec 15 13:15:00 GMT 2007


On Dec 13, 2007 4:29 PM, Daniel Jacobowitz <drow@false.org> wrote:
> On Thu, Dec 13, 2007 at 04:10:55PM -0800, Doug Evans wrote:
> > Ok to check in?  Or any suggestions for what's needed instead?
>
> Your patch seems strange to me.  Do we need the new fieldno /
> basetype, or not?  If we don't, we shouldn't be calculating it at all;
> if we do, there should be something detectable which breaks when you
> do this.  It's not just a cache, since the interface doesn't offer any
> other way to return the new fieldno / basetype besides in-place
> modification.

Hold the fort, I think I see what you're saying now.
I'll send another patch for review.



More information about the Gdb-patches mailing list