[RFA] Inform about new thread in a single place.

Vladimir Prus vladimir@codesourcery.com
Fri Dec 14 20:45:00 GMT 2007


On Friday 14 December 2007 22:47:21 Daniel Jacobowitz wrote:
> On Fri, Dec 14, 2007 at 10:40:20PM +0300, Vladimir Prus wrote:
> > Here's the revised patch. OK?
> 
> linux-nat.c, linux-thread-db.c, and win32-nat.c all print only under
> control of a verbose flag.  While we're unifying the code we should
> unify the behavior too - should this always be shown, or not?

I think it should always be shown.  I find it hard to believe
that user want to know about new thread on one platform, and don't
want on another platform.

> The call site in linux-nat.c never received the verbose flag, so it
> has not been printing for a while.

Right. That's why the patch removes the print there. The ChangeLog
entry I've posted had it backward, but in reality lin_lwp_attach_lwp
is called from linux-thread-db.c:attach_thread -- which did the printing.

Now that you mention it, it appears the 'verbose' parameter can be just removed.

- Volodya


 




More information about the Gdb-patches mailing list