[RFA v2] Allow cygwin native to compile with --enable-64-bit-bfd

Daniel Jacobowitz drow@false.org
Sun Dec 2 04:00:00 GMT 2007


On Sat, Dec 01, 2007 at 09:43:11PM -0500, Christopher Faylor wrote:
> I'd like to get opinions from other maintainers on the use of a macro
> for this case.  I don't like seeing unexplained double casts like this
> and I think a macro could make it clearer.
> 
> Daniel were you implying that you would just tolerate a macro here or
> do you think it's an ok idea.

I'm very familiar with this idiom, so the double cast stands out when
I see it.  If there were a macro I'd have to go figure out whether it
was doing something more subtle.  I'd write it this way, but not
complain if someone else wrote it differently.

> >2007-11-28  Pierre Muller  <muller@ics.u-strasbg.fr>
> >
> >	*win32-nat.c: Allow compilation if CORE_ADDR is 8 byte long.
> >	Add "gdb_stdint.h" dependency required for uintptr_t type use.

Added includes -> update Makefile.in.  Tom's been working on automatic
dependencies for GCC.  Maybe we can do something similar for GDB
soon...

-- 
Daniel Jacobowitz
CodeSourcery



More information about the Gdb-patches mailing list