[patch] target_read_string, potential memory leak.

msnyder@sonic.net msnyder@sonic.net
Wed Aug 8 22:03:00 GMT 2007


>
> msnyder@sonic.net writes:
>>> msnyder@sonic.net writes:
>>>> OK -- it would be pretty stupid to call target_read_string without
>>>> passing it a buffer, but if we're going to check it for null...
>>>
>>> I don't think the contract for target_read_string permits STRING to be
>>> null.  I think either the test should go, or we should add a
>>> gdb_assert (string).
>>
>> Agreed.  Thus?
>
> Agreed, thus.  :)

Committed.  Fiat.




More information about the Gdb-patches mailing list