[rfc] Fix qC handling in gdbserver

Markus Deuling deuling@de.ibm.com
Fri Apr 27 11:05:00 GMT 2007


Hi Pedro,

Pedro Alves wrote:
> All the other tests in the function seem to check for an
> extra '\0', ',' or ':' after the query name.  Shouldn't you do the
> same here?  Otherwise you are answering
> to all future queries starting with qC (Think or a gdbserver
> installed in rom in a board in the field, and connecting
> to it with gdb-cvs2020 :) )

yes, your're right. I changed the patch to use strcmp now. I just
wanted to save the overhead of a function call for two characters. But I 
would have missed qC<whatever> :-)

Thanks for review!


-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diff_gdbserver_fix
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20070427/f47c4333/attachment.ksh>


More information about the Gdb-patches mailing list