[PATCH] Don't call Insight hooks when not appropriate

Andrew STUBBS andrew.stubbs@st.com
Thu Mar 9 18:15:00 GMT 2006


Hi all,

I'm not really sure whether this should go to GDB patches or Insight so 
you've both got it.

The attached patch prevents annoying messages and dialogue boxes when 
sourcing command scripts and running user-defined commands. It stops all 
yes/no questions and all 'Type commands for ...' messages.

Output and prompts from these scripts are normally suppressed by GDB, 
but not by Insight.

In order to achieve this I had to find a way to tell the difference 
between the normal Insight input state, and the state when executing 
user commands - both were previously identified by instream==NULL. I 
have changed instream to -1 when running user-defined commands. An 
inspection of the uses of instream suggests this will not have any 
detrimental affects, but it is hard to be totally sure.

I know these hooks are marked deprecated, but we're still using them.

Andrew Stubbs
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: insight-dialogue.patch
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20060309/c66a8ea9/attachment.ksh>


More information about the Gdb-patches mailing list