patch for invalid hw breakpoints

[Eli Zaretskii]

[Patches should be sent to gdb-patches,; I redirected the thread.]

> Date: Thu, 01 Jun 2006 14:20:40 +0100
> From: Nathan Sidwell <nathan@codesourcery.com>
> 
> I have a remote target w/o hw watchpoint support.  I set a watchpoint only to 
> find that I then get an undeletable watchpoint as we try and remove it.
> 
> The bug is that when insert_bp_location fails to insert one of the watched 
> addresses for a watch expression it then goes and tries to remove all the 
> addresses of that watched expression, rather than just the previous fragments of 
> the expression.

And why is that a problem?  I'm sorry, but I couldn't figure out from
your description why removing a watch for an expression for which
insertion didn't happen causes trouble.  IIRC, it is supposed to
silently fail, and its only effect should be to cause GDB to be happy
that the watchpoint was completely removed.  What am I missing?