Fix non-pointer-sign gcc warnings
Daniel Jacobowitz
drow@false.org
Mon Jan 16 13:42:00 GMT 2006
On Sun, Jan 15, 2006 at 11:04:42PM -0800, Jim Blandy wrote:
> On 1/15/06, Daniel Jacobowitz <drow@false.org> wrote:
> > The one in macroexp.c is not a real bug but I think GCC is justified in
> > not being able to see through it. The one in stabsread.c is a real bug
> > and would cause GDB to crash on bad stabs.
>
> Would it make more sense to have gather_arguments actually always
> assign something to *ARGC_P? This would treat *ARGC_P as more like
> part of the return value, which is how I see it.
I don't know; the "leave reference arguments alone on error" behavior
is a pretty common convention in C, and somebody went to the trouble of
documenting it above the function - looks like it was you :-)
Either way makes sense.
--
Daniel Jacobowitz
CodeSourcery
More information about the Gdb-patches
mailing list