RFA: ensure binary objects opened in binary mode

Christopher Faylor me@cgf.cx
Wed Feb 22 17:06:00 GMT 2006


On Wed, Feb 22, 2006 at 12:30:46AM -0500, Charles Wilson wrote:
>My point: while the concept in the second patch is extremely simple (so 
>simple that a pair of automated scripts can create it), it still ends up 
>modifying 48 different files, deleting 1 (or 4) lines from each.  I'm 
>not sure that the FSF guidelines permit you to accept that patch from 
>me, as I do not have an assignment on file for the gdb project.  This 
>second patch is trivial in concept and obvious in implementation, but 
>changes a LOT more than a dozen lines.
>
>However, I release the two scripts above to the public domain, and they 
>can be used by anyone for any purpose.  Have fun.

I appreciate the thoroughness with which you approached this patch and,
personally, have no problem with your checking this in.  Unless your
ssh key has changed, you should still have the ability to check things
into the "src" CVS repository where gdb (and cygwin) resides.

However, this patch and your method for patching, will, of course,
require someone other than me to approve it.

cgf



More information about the Gdb-patches mailing list