Enhanced language support for Modula-2

Mark Kettenis mark.kettenis@xs4all.nl
Tue Feb 21 20:57:00 GMT 2006


> Date: Tue, 21 Feb 2006 22:46:08 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> Thanks.  My comments are below.
> 
> > +      error (_("type not handled in m2_type_print_varspec_prefix()"));
> 
> Please don't append "()" to indicate that you are talking about a
> function; just name the function.  "foo()" looks like a call to `foo'
> with no arguments, which is not what you want to say.
> 
> > +      error (_("type not handled in m2_type_print_varspec_suffix()"));
> 
> Same here.

Ah, but error messages intended for the user shouldn't mention
function names in the first place.  This should probably be an
internal_error() instead.

Mark



More information about the Gdb-patches mailing list