[RFA] gdbserver/server.c: Replace 2x strlen() by a variable

Andreas Schwab schwab@suse.de
Thu Dec 21 11:48:00 GMT 2006


Joel Brobecker <brobecker@adacore.com> writes:

>> ChangeLog:
>> 
>> 	* server.c (handle_general_set): New variable len instead
>> 	of using strlen two times.
>
> Actually, since the same string is duplicated a couple of times,
> I would also suggest declaring a constant string "QPassSignals:"
> and use the constant instead of risking a typo... How about:
>
>    const char str[] = "QPassSignals:";

Or just define it as a macro.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



More information about the Gdb-patches mailing list