[PATCH] remove download_write_size variable

[Vladimir Prus]

On Monday 31 July 2006 21:16, Eli Zaretskii wrote:
> > From: Vladimir Prus <vladimir@codesourcery.com>
> > Date: Mon, 31 Jul 2006 16:22:57 +0400
> > Cc: gdb-patches@sources.redhat.com
> >
> > > > 	* symfile.c (download_write_size): Remove.
> > > > 	(show_download_write_size): Remove.
> > > > 	(load_section_callback): Don't use download_write_size.
> > > > 	(_initialize_symfile): Don't register download_write_size.
> > >
> > > I can find references to download-write-size on the Internet, e.g. in
> > > FAQs suggesting how to get better write performance.  They all seem to
> > > push it as high as memory-write-packet-size, though, which suggests we
> > > do not need both limits.
> > >
> > > I think it's reasonable to remove it.  However, you'll have to also
> > > remove it from the manual (it's a documented command).
> >
> > Are you sure? Grep does not find any occurrence in docs, on current
> > mainline.
>
> It's in the node called "Target Commands".

Thanks. I was searching with underscores in names, not dashes ;-)

>
> > === gdb/NEWS
> > ==================================================================
> > --- gdb/NEWS	(/mirrors/gdb)	(revision 315)
> > +++ gdb/NEWS	(/patches/download_write_size/gdb)	(revision 315)
> > @@ -18,6 +18,8 @@
> >  Kernel Object Display, an embedded debugging feature which only worked
> > with an obsolete version of Cisco IOS.
> >
> > +The 'download_write_size' variable.
> > +
>
> This variable is not user-visible.  You need to mention the command,
> not the C variable.

Please find the new patch attached. Doc dir changelog is:

2006-08-01  Vladimir Prus  <vladimir@codesourcery.com>

	* gdb.texinfo (Target Commands): Remove 
	'set download-write-size' and 'show download-write-size'.


- Volodya
-------------- next part --------------
A non-text attachment was scrubbed...
Name: download_write_size__gdb.diff
Type: text/x-diff
Size: 3785 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20060801/92486c82/attachment.bin>