[RFC] New target, Renesas M32C
Daniel Jacobowitz
drow@false.org
Thu Apr 20 16:33:00 GMT 2006
On Thu, Apr 13, 2006 at 02:09:15PM -0700, Michael Snyder wrote:
> This target architecture has already been added to gcc and binutils.
> Here's the gdb port.
I think this is fine. I only skimmed it; the most interesting bits are
the prologue analysis, which I've looked over before. The rest nothing
jumped out at me. Other than that I've only very small comments:
- Please add it to NEWS as Eli requested.
- Are you volunteering to maintain this port? If so, please add
a MAINTAINERS entry. If not, I don't want a port added without
a maintainer.
- Instead of this:
> + #if defined (HAVE_STRING_H)
> + #include <string.h>
> + #endif
use "gdb_string.h".
--
Daniel Jacobowitz
CodeSourcery
More information about the Gdb-patches
mailing list