RFA: Don't use -Wuninitialized if CFLAGS omits -O

Joel Brobecker brobecker@adacore.com
Sat Mar 12 09:05:00 GMT 2005


Jim,

> 2005-02-28  Jim Blandy  <jimb@redhat.com>
> 
> 	Avoid warnings due to the use of -Wuninitialized without -O.
> 	* configure.ac (build_warnings): Include -Wuninitialized only if
> 	CFLAGS is unset at configure time, or CFLAGS is set and includes
> 	some -O option other than -O0.
> 	* configure: Regenerated.

I think there is a slight problem that broke the build with non-GNU
bourne shells. We have a build failure on our solaris 2.8 machine,
for instance. Here is what I think the problem is:

> + # GCC supports -Wuninitialized only with -O or -On, n != 0.
> + if test x${CFLAGS+set} == xset; then
                           ^^
I think the "==" should be "=", no? That's what "man test" documents.
But I've never been a shell guru...
                          
-- 
Joel



More information about the Gdb-patches mailing list