PATCH: Avoid accidentally opening files for write

[Mark Mitchell]

Nick Clifton wrote:
> Hi Mark,
> 
>>> patch to a generic part of BFD it would be good if you could also 
>>> test with a --enable-targets=all build, just to make sure.
> 
> 
>> I didn't know about that, but will try it before check-in. 

It worked -- except for a warning from the new ms1 port when compiling 
readelf.  I worked around that, and committed anyhow, as that was an 
unrelated issue.

>> I could tighten the test to check for just what ISO C requires, which 
>> is that the characters must occur at the start of the string, so using 
>> strchr is probably incorrect.
> 
> No please just make the change before check-in.

I've attached the version committed.  It's now on both mainline and 
csl-arm-20050325-branch.  Thanks for the quick review!

GDB folks, may I now commit the other half of the patch?

Thanks,

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: bfd.fopen.patch
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20050607/9cbfc160/attachment.ksh>