[commit] Mark up add_com, add_info and add_prefix_cmd

Daniel Jacobowitz drow@false.org
Tue Feb 15 19:02:00 GMT 2005


On Tue, Feb 15, 2005 at 10:48:14AM -0500, Andrew Cagney wrote:
> FYI,
> committed,
> Andrew

Andrew, both Eli and I have asked you to stop doing committing these
patches.

If you intend to continue ignoring the concerns of other GDB
maintainers, I will ask the GDB steering committee to temporarily
remove your write privileges and see if that convinces you to discuss
your concerns in a civilized fashion.

MAINTAINERS has this to say:
  An "obvious fix" means that there is no possibility that anyone will
  disagree with the change.

  A good mental test is "will the person who hates my work the most be
  able to find fault with the change" - if so, then it's not obvious and
  needs to be posted first. :-)

  Something like changing or bypassing an interface is _not_ an obvious
  fix, since such a change without discussion will result in
  instantaneous and loud complaints.

I understand that you are checking these in under the "Global
Maintainers" mandate rather than the "Obvious Fix" mandate.  But the
same principle applies.  If a change results in instantaneous and loud
complaints, IT SHOULD NOT BE CHECKED IN WITHOUT DISCUSSION.

I find your behavior painfully ironic coming from a maintainer who
steadfastly supported the position that global maintainers needed to
ask for approval.  You're demonstrating why that convention existed.

If you, or your employer, desperately need an internationalized version
of GDB 6.4, then please do it locally instead of abusing the FSF
repository in this fashion.

-- 
Daniel Jacobowitz
CodeSourcery, LLC



More information about the Gdb-patches mailing list