[gdbserver/patch] Z packet support
Orjan Friberg
orjan.friberg@axis.com
Tue Feb 1 12:09:00 GMT 2005
Daniel Jacobowitz wrote:
>
> You missed the most important problem with the previous posting, I'm
> afraid - it's still whitespace mangled. Please don't send patches
> using format=flowed; it's very good for text, but lousy for data.
> Either disable it or just attach them. I've more or less figured out
> the algorithm by which it ate your patch, but it's pretty tedious to
> hand-merge; could you resend?
Sure. (Until I figure it out, I'll be attaching patches instead of inlining
them. Sorry for the trouble.)
> CORE_ADDR is always a long long in gdbserver, so your sizeof (addr)
> probably doesn't work right for 32-bit targets. I guess sizeof (void
> *) is always right for this, though... at least for the kinds of
> targets gdbserver supports now.
FWIW, recurse.exp and watchpoints.exp ran fine on CRISv32 (32-bit target) when a
64-bit address was sent. I changed it nonetheless, and tweaked the comment.
--
Orjan Friberg
Axis Communications
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20050201/3b04024f/attachment.ksh>
More information about the Gdb-patches
mailing list