[PATCH] Allow spaces in filenames to load command

Andrew STUBBS andrew.stubbs@st.com
Wed Dec 7 23:25:00 GMT 2005


Jim Blandy wrote:
> Here's what I think we should do.  Folks who've worked a lot with the
> target vector, please review.

I attach a patch which does what you suggested. I also updated the help 
for the load command to mention the offset.

I have tested it and found no extra test failures.

> This moves towards a well-defined interface for target_load.  I don't
> think it's fair to ask you to go in and fix
> freds-old-S100-bus-board-monitor.c; in the future, if people run into
> problems with specific targets not expecting the quotation, we can fix
> them, since we'll then have a person who can actually test the change.

If nobody ever uses a file name with space, tab, single or double quotes 
or an escape slash then custom target_load function should see no 
difference.

Similarly, as long as all the places that use generic_load pass through 
the arguments they got from load_command then they should see no 
differences either.

Andrew Stubbs
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: load-2.patch
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20051207/8681657f/attachment.ksh>


More information about the Gdb-patches mailing list