PATCH: remove unused variables and code in value_assign
Jim Blandy
jimb@redhat.com
Tue Sep 14 03:02:00 GMT 2004
Committed as obvious.
2004-09-13 Jim Blandy <jimb@redhat.com>
* valops.c (value_assign): 'use_buffer' is initialized to zero,
and never assigned to. Delete it, and the 'if (use_buffer)'
clauses. Delete 'raw_buffer', since it is now unused.
Index: gdb/valops.c
===================================================================
RCS file: /cvs/src/src/gdb/valops.c,v
retrieving revision 1.130
diff -c -p -r1.130 valops.c
*** gdb/valops.c 14 Sep 2004 02:51:27 -0000 1.130
--- gdb/valops.c 14 Sep 2004 02:58:34 -0000
*************** value_assign (struct value *toval, struc
*** 525,532 ****
{
struct type *type;
struct value *val;
- char raw_buffer[MAX_REGISTER_SIZE];
- int use_buffer = 0;
struct frame_id old_frame;
if (!toval->modifiable)
--- 525,530 ----
*************** value_assign (struct value *toval, struc
*** 591,602 ****
changed_addr = VALUE_ADDRESS (toval) + VALUE_OFFSET (toval);
dest_buffer = buffer;
}
- else if (use_buffer)
- {
- changed_addr = VALUE_ADDRESS (toval) + VALUE_OFFSET (toval);
- changed_len = use_buffer;
- dest_buffer = raw_buffer;
- }
else
{
changed_addr = VALUE_ADDRESS (toval) + VALUE_OFFSET (toval);
--- 589,594 ----
*************** value_assign (struct value *toval, struc
*** 683,690 ****
modify_field (buffer + byte_offset,
value_as_long (fromval),
VALUE_BITPOS (toval), VALUE_BITSIZE (toval));
- else if (use_buffer)
- memcpy (buffer + VALUE_OFFSET (toval), raw_buffer, use_buffer);
else
memcpy (buffer + byte_offset, VALUE_CONTENTS (fromval),
TYPE_LENGTH (type));
--- 675,680 ----
More information about the Gdb-patches
mailing list