[patch/rfc] Eliminate TARGET_HAS_HARDWARE_WATCHPOINTS

[Andrew Cagney]

>>> Date: Sun, 12 Sep 2004 12:31:23 -0400
>>> From: Andrew Cagney <cagney@gnu.org>
>>> Cc: Daniel Jacobowitz <drow@false.org>, gdb-patches@sources.redhat.com
>>> 
>>
>>>> > I'm not sure the mere presence of DR_* automatically means that
>>>> > hardware watchpoints are supported at run time.  I'd prefer to hear
>>>> > that from Mark or someone else who could tell for sure.
>>>> > 
>>>> > In any case, if the above is true, then there should be no problem to
>>>> > write an Autoconf test that would replace
>>>> > TARGET_HAS_HARDWARE_WATCHPOINTS.  As soon as that is posted here, I
>>>> > will withdraw all my objections to removing the old macro in favor of
>>>> > the new mechanism.
>>
>>> 
>>> This assumes that we've access to machines to test it on, and the code 
>>> being modified is even being used / worth retaining.  Resolving both of 
>>> those takes this from a no-problem task to something best handled 
>>> separatly, and something that should not block this current patch.

I've committed this part of my change:

> - core GDB no longer refers to TARGET_HAS_HARDWARE_WATCHPOINTS
> At one stage target.h had definitions dependant on this macro, but no more.  This patch removes the no-longer-needed defintion from configurations, such as GNU/Linux.

w.r.t.,

> Sorry, the person who wants to submit a patch for inclusion should do
> the necessary reasearch required to verify that the patch is doing
> TRT.

That was done.  To have anyone do more is a waste of effort.

Anyway, this is all have been beaten to death in this thread, we are
just reiterating the same issues again and again.

Andrew

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diffs
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20040913/9dccdc95/attachment.ksh>