[RFA] patch to remove language-dependent numeric output support
Andrew Cagney
cagney@gnu.org
Sat Sep 11 02:03:00 GMT 2004
> [Ooops. I see my previous Subject line was a bit mangled. So here is
> the same patch with a more meaningful subject.]
Think your self lucky - my disk failed and ate it :-)
> At Andrew's request, I've prepared a patch that removes the
> (essentially unused) features in the language vector and elsewhere
> that provide for language-dependent integral output formats. The
> patch below causes GDB to use C-format throughout instead. This change
> does indeed allow for a bit of brush removal.
>
> The idea is that if language-specific formatting were ever to be
> re-introduced, it would be via a function in the language vector. (I'd
> suggest that such a function take a raw string of digits and perhaps
> their radix, and work from that. For C, it would stick 0x or 0 in
> front, according to radix and value; for Ada, it would stick RADIX# in
> front and # after for non-decimal radices).
>
> The patch would have been a lot shorter, but several name changes seemed
> indicated. Comments solicited.
the code changes are ok - the language specific changes being mindless
follow suit (and I think I'll have a drink, thanks!).
Just some notes though:
> (local_decimal_format_custom): Remove.
>
> * utils.c: (int_string): New function.
I suspect that the the blank lines aren't needed - blank lines separate
commits rather than separate parts of the same commit - whichever.
> functions. We have to split this up into separate print
> - statements because local_hex_string returns a local static
> + statements because hex_string returns a local static
can you file a bug report - that pre-existing behavior is a recipe for
desaster :-(
Makefile.in will eventually need an update. If you want to do it
there's a script (gdb_makefile.in) hanging off of the ari web page that
you might find useful. Fixing the file is obvious.
I suspect that the special Makefile rule for printcmd.o can be deleted -
something for later. Ditto.
Again, thanks. Now where were we with Ada.
Andrew
More information about the Gdb-patches
mailing list