RFA: if/while commands in user-defined command behave differently

Jason Molenda jmolenda@apple.com
Fri Sep 10 00:58:00 GMT 2004


On Sep 9, 2004, at 5:55 PM, Michael Chastain wrote:

> Jason Molenda <jmolenda@apple.com> wrote:
>> OK, I switched to gdb_test_multiple, thanks for the feedback.  I
>> haven't used gdb_test_multiple before, but I think this patch is
>> correct.
>
> Just assert that you re-tested it, and it's approved.
> (I'm a weird combination of anal-retentive and trusting).

Yes, sorry, x86 Linux gcc 3.4.0 dwarf2, no failures (with the patch to 
cli-script.c, of course :)

>> I haven't heard anything back on the CLI change.  If the testsuite
>> change is approved, should I commit that and file a PR to track the
>> bug?  :-)
>
> Actually, I like it that way.  But you've been working on GDB longer
> than I have, so I leave it to your judgement when/if to file a PR.

Cool.  I have to take off in a few minutes, but I'll file a PR and 
commit the testsuite addition tomorrow.

Thanks again for the help,


J



More information about the Gdb-patches mailing list