RFA: if/while commands in user-defined command behave differently

Jason Molenda jmolenda@apple.com
Fri Sep 10 00:40:00 GMT 2004


On Sep 9, 2004, at 7:34 AM, Michael Chastain wrote:

> send_gdb / gdb_expect are old; can you can upgrade this to the modern
> interface, gdb_test_multiple?  With gdb_test_multiple you don't need
> the default "$gdb_prompt $" and timeout clauses.
>
> The idea is good; it just needs gdb_test_multiple.  Just do that and
> re-test and re-submit.


OK, I switched to gdb_test_multiple, thanks for the feedback.  I 
haven't used gdb_test_multiple before, but I think this patch is 
correct.

I haven't heard anything back on the CLI change.  If the testsuite 
change is approved, should I commit that and file a PR to track the 
bug?  :-)

Jason


[gdb/ChangeLog]
2004-09-08  Jason Molenda  (jmolenda@apple.com)

         * cli/cli-script.c (read_next_line): Accept zero or more 
whitespace
         chars after 'if' or 'while' commands in user-defined commands.

[gdb/testsuite/ChangeLog]
2004-09-09  Jason Molenda  (jmolenda@apple.com)

         * gdb.base/define.exp: Two new tests to verify zero space chars
         after 'if' and 'while' commands in a user-defined command is 
correctly
         parsed.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pa2.txt
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20040910/3643878a/attachment.txt>


More information about the Gdb-patches mailing list