[commit] Let {TM,XM,NM}_FILE specify a path

Andrew Cagney cagney@gnu.org
Thu Sep 9 15:17:00 GMT 2004


>>> Date: Fri, 03 Sep 2004 12:38:18 -0400
>>> From: Andrew Cagney <cagney@gnu.org>
>>> Cc: gdb-patches@sources.redhat.com
>>> 
>>
>>>> > Perhaps we should rename TM_FILE to something like TM_INCLUDE, then.
>>
>>> 
>>> If you prefer, I can rename it to DEPRECATED_TM_INCLUDE when committing 
>>> my pending deprecation patch.
> 
> 
> If we change the functionality of TM_FILE (so it can now name any
> file), then it doesn't seem to be deprecated.  Thus,
> DEPRECATED_TM_INCLUDE seems an inappropriate name to me.

I've now prototyped this change vis:
	TM_FILE -> TM_INCLUDE
	NAT_FILE -> NM_INCLUDE (for consistency)
	XM_FILE -> XM_INCLUDE
and found that it didn't help.

TM_FILE specifies the name of the file that is linked to "tm.h".  My 
patch does not change this.  It just removes a restriction on what could 
be specified for that file.

If we were to say, eliminate "tm.h", and instead include the tm file 
directly than I could certainly see some sort of name change vis:
	#ifdef TM_INCLUDE_FILE
	#include TM_INCLUDE_FILE
	#endif
I've also prototyped this.  I discarded it - I didn't see sufficient 
value add.

Andrew




More information about the Gdb-patches mailing list