[commit] Cleanup parse_frame_specification

Andrew Cagney cagney@gnu.org
Sat Oct 30 00:19:00 GMT 2004


Hello,

The attatched overhauls parse_frame_specification, creating the worker 
parse_frame_specification_1.  The latter takes additional "reason" (for 
get_selected_frame) and selected_frame_p (true when selected frame was 
used).  Doing this let me:

- eliminate several deprecated_selected_frame references
- delete a switch fall-through (missing 'break')
- make a parameter constant
- eliminate a get_frame_base (uses an ID instead)

However, the basic structure is still there.  And it preserves the 
behavior where the outer-most, rather than inner-most, frame matching an 
address parameter is selected.

Committed,
Andrew

PS: Perhaphs:
   frame STACK_ADDR
should be extended to also allow
   frame STACK_ADDR CODE_ADDR
and
   frame STACK_ADDR CODE_ADDR SPECIAL_ADDR
i.e., identify a frame based on its id.

PPS: No this wasn't prompted by Felix's post.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diffs
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20041030/8341dfc8/attachment.ksh>


More information about the Gdb-patches mailing list