[PATCH]: SH 2a - Part 4: Begin using RETURN_VALUE
Wed Oct 6 09:07:00 GMT 2004
On Oct 5 10:11, Elena Zannoni wrote:
> Corinna Vinschen writes:
> > this is SH 2a patch 4. It does not introduce new functionality, but
> > instead it converts sh-tdep.c to use RETURN_VALUE instead of
> > STORE_RETURN_VALUE, EXTRACT_RETURN_VALUE, RETURN_VALUE_ON_STACK and
> > USE_STRUCT_CONVENTION.
> > What this patch does *not* do is this: I would love to rename the
> > functions sh_default_store/extract_value and sh3e_sh4_store/extract_value
> > to sh_store/extract_value_nofpu and sh_store/extract_value_fpu.
> > This would decouple the sense of these functions from the cpu names,
> > which is rather irritating and wrong anyway. If that's ok, I'd
> > submit another patch which just performs the renaming.
> It wasn't wrong and irritating at the time it was introduced.
Yes, that's apparently right. As I wrote, "I would love to...", because
time has gone a bit over that naming scheme and I think, changing the
names to reflect their usage in a more general way would help when reading
the code in future.
Is it ok to rename them?
> > BEFORE AFTER
> Thanks for providing the test results. Are these with
> sources.redhat.com sources? Or some internal only tree? What version
> of gcc? So we have a good reference point.
I used sources sources (erm...) to evaluate these results, exactly
CVS HEAD from 2004-09-08. GCC was a 3.4 with SH2a patches applied.
Cygwin Project Co-Leader
Red Hat, Inc.
More information about the Gdb-patches