[RFA]: Remove warnings from ada-exp.tab.c compilation

Andrew Cagney cagney@gnu.org
Tue Oct 5 19:47:00 GMT 2004


> +/* FIXME: Temporary measure to remove warning.  The function

I'd write this as:

	/* FIXME: hilfingr/2004-10-05: Hack to remove warning.  ...

so that who added the note and when are clear.  If you're curious grep 
for this pattern in the sources and quickly discover how old some of 
those tempoary hacks are :-)

otherwize ok,
Andrew

PS:
+      tempbuf = (char *) realloc (tempbuf, tempbufsize);
the cast is redundant - realloc returns (void *).

Andrew




More information about the Gdb-patches mailing list