[patch/RFA] multiarch INSTRUCTION_NULLIFIED

Mark Kettenis mark.kettenis@xs4all.nl
Tue Nov 23 19:33:00 GMT 2004


   Date: Tue, 23 Nov 2004 09:49:37 -0800
   From: Randolph Chung <randolph@tausq.org>

   i did some more investigations.... turns out this is not a cosmetic
   piece of code at all :)

   suppose we have a function that ended with a branch-with-nullify-next
   instruction back to the caller. if you did a "step" on the branch, and
   we don't skip the nullified instruction, we would end up on the
   nullified instruction which actually belongs to the next function.

   comments? ok to check in?

OK, if you make sure you wrap the lines that are too long.

Mark

   2004-11-23  Randolph Chung  <tausq@debian.org>

	   * arch-utils.c (generic_instruction_nullified): New.
	   * arch-utils.h (generic_instruction_nullified): New.
	   * gdbarch.sh (instruction_nullified): New method.
	   * gdbarch.c: Regenerate.
	   * gdbarch.h: Regenerate.
	   * infrun.c (INSTRUCTION_NULLIFIED): Delete.
	   (handle_inferior_event): Replace INSTRUCTION_NULLIFIED with calls to
	   new gdbarch method.
	   * config/pa/tm-hppa.h (INSTRUCTION_NULLIFIED): Delete definition.
	   * hppa-tdep.c (hppa_instruction_nullified): Remove prototype and make
	   static.  Rewrite to work directly off the passed regcache.
	   (hppa_gdbarch_init): Set instruction_nullified method.



More information about the Gdb-patches mailing list