[rfa/testsuite/threads] ping: manythreads.exp
Jeff Johnston
jjohnstn@redhat.com
Thu Jun 3 19:31:00 GMT 2004
Michael Elizabeth Chastain wrote:
> ms> So... this means it will unconditionally wait, right?
> ms> Can I assume that "after 1000" means milliseconds, not seconds?
>
> Yes, and yes. The "milliseconds" part is in the TCL book so it's
> okay to rely on it.
>
> ms> That's my only concern, that if it fails for some reason, it
> ms> will block for a long time. If that's not the case, then the
> ms> change is ok with me (if it's ok with Jeff).
>
> Hey Jeff -- is this okay with you?
>
Yes, please go ahead.
> ms> Michael, I notice that the same idiom is used in pthreads.exp;
> ms> do you think your change would also be appropriate there, and
> ms> if so, would you mind making it?
>
> I think it would be good there too. Right now, the code says:
>
> sleep 1
> set description "Stopped with a ^C"
> after 1000 [send_gdb "\003"]
> gdb_expect {
> ...
> }
>
> so the test script is going into the gdb_expect and pausing there
> until the 'after' block executes. There's no need to be running
> the send_gdb "\003" in parallel with gdb_expect. So I'll make a
> patch for this too. (Also it looks bizarre to use both 'sleep'
> and 'after' ... gotta do a little research).
>
> Michael C
>
More information about the Gdb-patches
mailing list