[RFA] read_reg() patch
Mark Kettenis
kettenis@chello.nl
Wed Jul 21 20:36:00 GMT 2004
From: "Martin M. Hunt" <hunt@redhat.com>
Date: Tue, 20 Jul 2004 12:16:51 -0700
2004-07-20 Kevin Buettner and Martin Hunt <hunt@redhat.com>
* dwarf2-frame.c (read_reg): Add a call to
store_unsigned_integer.
This extracts the least significant register_size() bits and
extends it to the size of a pointer. Without this, big-endian
targets where pointer size != register size breaks.
The formatting of this ChangeLog entry isn't right. Please look at
the existing ChangeLogs to see how you should write them. Also move
the explanation of what the code does to the code. The ChangeLog
should just say what's changed, not why.
I also think that the code itself is pretty unreadable. There are too
many nested function calls. I think it could be improved by using a
(temporary) local variable to store the result of
extract_unsigned_integer().
Mark
More information about the Gdb-patches
mailing list