[PATCH] Don't try to unwind the PC in frame.c:get_prev_frame()

Andrew Cagney cagney@gnu.org
Mon Jan 5 23:46:00 GMT 2004


>    Date: Mon, 05 Jan 2004 16:57:15 -0500
>    From: Andrew Cagney <cagney@gnu.org>
> 
>    > Andrew, I saw no use for retaining some of the commentd, so I delete
>    > the thing completely.
> 
>    Can just you add a -ve comment stating why a test for PC==0 does not 
>    belong in that function?  I'm pretty much certain that someone will 
>    eventually try to re-add a very similar test (via inside_entry_func for 
>    instance).
> 
> Well, I just added a regression test, shouldn't that be enough?

Not round here :-(  Better to retain the relevant information so that 
the rationale is written down and available at our finger tips.   If you 
don't want to do it, I will.

Andrew

> (You just reminded me that I should remove the PC == 0 check from
> inside_entry_func too).




More information about the Gdb-patches mailing list