[PATCH] Fix compilation of tui/tui.c
Andrew Cagney
cagney@gnu.org
Sat Feb 28 16:59:00 GMT 2004
> What portability problem.
>
> The TUI code is including header files and using library functions
> that we've never used before in GDB. We've already seen the fall-out
> from this on HP-UX and Solaris, and now on FreeBSD. I'm just afraid
> that more of these problems will surface when somebody tries to build
> GDB other platforms.
There aren't that many other systems left! As with off64_t, while
certainly a step into the unknown, we've done our homework - notice,
paced patches, and testing it on a varity of systems. The only real way
to flush out the remaining problems is to push it through to a release.
> Is there a reason for changing "" to <>, it breaks some of GDB's
> scripts.
>
> I changed because we seem to use <> everywhere else in GDB for the
> readline includes, e.g. event-top.c, completer.c. I think it's good
> to be consistent; you get less surprises that way.
I'll change them so that they are consistent. gdb_makefile.sh:
http://sources.redhat.com/gdb/current/ari/gdb_makefile.sh
knows about "..." includes.
Andrew
More information about the Gdb-patches
mailing list