[RFA/dwarf] Don't process types multiple times

David Carlton carlton@kealia.com
Wed Feb 25 17:02:00 GMT 2004


On Tue, 24 Feb 2004 23:42:06 -0500, Daniel Jacobowitz <drow@false.org> said:

> There are two ways that we can process a general DIE: process_die or
> read_type_die.  Children of particular DIE types may be processed
> directly, but these are the only major dispatch points.  It's
> interesting to notice that almost everything called from
> read_type_die starts with "if (die->type) return": everything but
> enumeration types and aggregate types, in fact.  This means that if
> the first reference to an enumeration or aggregate type is a
> DW_AT_type or DW_AT_containing_type in a DIE numerically before the
> type's DIE, we'll end up calling new_symbol for it twice.

Yeah, that had been bothering me for a while, too.

In the FIXME comment, could you add your name and the date?

David Carlton
carlton@kealia.com



More information about the Gdb-patches mailing list