Avoid obstack_free in cp-namespace.c

Eli Zaretskii eliz@elta.co.il
Tue Feb 10 05:44:00 GMT 2004


> Date: Mon, 9 Feb 2004 16:10:10 -0500
> From: Daniel Jacobowitz <drow@mvista.com>
> 
> -  char *name_copy = obsavestring (name, len, &objfile->objfile_obstack);
> -  struct symbol *sym = lookup_block_symbol (block, name_copy, NULL,
> -					    VAR_DOMAIN);
> +  char *name_copy = alloca (len + 1);
> +  struct symbol *sym;
> +
> +  memcpy (name_copy, name, len);
> +  name_copy[len] = '\0';

How large can the value of `len' be?  I believe we have some coding
guidelines against using alloca for allocations that are too large.



More information about the Gdb-patches mailing list