[patch/rfc] Fix inside entry func call
Andrew Cagney
cagney@gnu.org
Tue Feb 3 22:19:00 GMT 2004
> On Mon, Feb 02, 2004 at 11:06:15PM -0500, Andrew Cagney wrote:
>
>> Hello,
>>
>> This, cleans up one part of a long dangling thread. Per:
>> http://sources.redhat.com/ml/gdb-patches/2003-11/msg00462.html
>> This modifies the unwind code so that it uses the test:
>>
>> + && get_frame_func (this_frame) == entry_point_address ()
>>
>> that that in place, the old inside_entry_func can be made static to
>> blockframe.c. This should reduce Kevin's patch to just doco + frame.c
>> tweaks.
>>
>> comments?
>
>
> Please re-read that discussion. Particularly:
>
> http://sources.redhat.com/ml/gdb-patches/2003-11/msg00459.html
>
> in which I asked you to leave the call to inside_entry_func and change
> its implementation. You asked for other legitimate uses of this
> function, and I gave you some.
Sorry, I'm lost. Right now, even without this patch, there is only one
call path to that function:
get_prev_frame
legacy_get_prev_frame
legacy_frame_chain_valid
inside_entry_func
It is there to prop up legacy code. Given this, I even considered
deleting it (or folding it into legacy_frame_chain_valid).
Do you want me to add a new separate static frame.c:inside_entry_func?
Andrew
More information about the Gdb-patches
mailing list