PATCH: fix indentation in remote.c:fetch_register_using_p

Jim Blandy jimb@redhat.com
Tue Dec 21 21:43:00 GMT 2004


Andrew Cagney <cagney@gnu.org> writes:

> >     if (buf[0] != 0 && buf[0] != 'E') {
> 
> Close, but no cigar.  Note the ``}'' :-)

That's what I get for using Emacs instead of gdb_indent.sh.  Here's
what that script does.  I've committed it.

2004-12-21  Jim Blandy  <jimb@redhat.com>

	* remote.c (fetch_register_using_p): Fix formatting.
	
Index: gdb/remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.155
diff -c -p -r1.155 remote.c
*** gdb/remote.c	17 Dec 2004 22:19:51 -0000	1.155
--- gdb/remote.c	21 Dec 2004 21:18:39 -0000
*************** fetch_register_using_p (int regnum)
*** 3192,3211 ****
    p += hexnumstr (p, regnum);
    *p++ = '\0';
    remote_send (buf, rs->remote_packet_size);
!   if (buf[0] != 0 && buf[0] != 'E') {
!     p = buf;
!     i = 0;
!     while (p[0] != 0) {
!       if (p[1] == 0) {
!         error("fetch_register_using_p: early buf termination");
!         return 0;
!       }
!       regp[i++] = fromhex (p[0]) * 16 + fromhex (p[1]);
!       p += 2;
      }
-     regcache_raw_supply (current_regcache, regnum, regp);
-     return 1;
-   }
  
    return 0;
  }
--- 3192,3214 ----
    p += hexnumstr (p, regnum);
    *p++ = '\0';
    remote_send (buf, rs->remote_packet_size);
!   if (buf[0] != 0 && buf[0] != 'E')
!     {
!       p = buf;
!       i = 0;
!       while (p[0] != 0)
! 	{
! 	  if (p[1] == 0)
! 	    {
! 	      error ("fetch_register_using_p: early buf termination");
! 	      return 0;
! 	    }
! 	  regp[i++] = fromhex (p[0]) * 16 + fromhex (p[1]);
! 	  p += 2;
! 	}
!       regcache_raw_supply (current_regcache, regnum, regp);
!       return 1;
      }
  
    return 0;
  }



More information about the Gdb-patches mailing list