[RFA]: Modified Watchthreads Patch

Daniel Jacobowitz drow@false.org
Fri Dec 10 14:21:00 GMT 2004

On Fri, Dec 10, 2004 at 02:20:39PM +0200, Eli Zaretskii wrote:
> Hmm... the new function insert_watchpoints_for_new_thread is called
> only by ia64_linux_new_thread.  Is there any policy for functions that
> are only used by a single port?  Do we care that all the other GDB
> builds will get a useless function compiled into them?  Should we
> perhaps #ifdef it away conditioned on some symbol?

Let's not.  Conditional compilation is bad... if it were more than a
single function, we could move it into its own file.

However, I think ia64_linux_new_thread's use should be taken as an
example.  If I understand Jeff's patch correctly, a number of other
targets with hardware watchpoints will need it also.

Daniel Jacobowitz

More information about the Gdb-patches mailing list