RFA fix conversion of little-byte big-word floats to doublest
Sat Dec 4 16:01:00 GMT 2004
On Sat, 04 Dec 2004 10:44:30 EST, Daniel Jacobowitz <email@example.com>
> On Sat, Dec 04, 2004 at 02:38:00PM +0000, Richard Earnshaw wrote:
> > This patch fixes a bug in get_field which meant that we incorrectly
> > converted mixed-endian floats (ARM FPA style) into the internal doublest
> > format. This short change fixes over 300 testsuite failures in a combined
> > arm/thumb testsuite run on arm-elf.
> > * doublest.c (get_field): Correctly extract floatformat_littebyte_bigwo
> > fields.
> > OK?
> Could you summarize for me how this is supposed to work? This means
> that get_field treats littlebyte_bigword exactly the same as little.
> There's another copy of get_field in libiberty (I don't know why there
> are two) which treats it exactly the same as big, instead. I don't
> know how that works either, but it seems the two ought to agree.
The caller has pre-converted the word order into a pure little-endian
format. See convert_format_to_doublest.
Similar tricks are played on the reverse conversion.
More information about the Gdb-patches