[RFC/RFA] target.c: Check current_target in target_resize_to_sections

Nathan J. Williams nathanw@wasabisystems.com
Fri Aug 27 14:57:00 GMT 2004


Andrew Cagney <cagney@gnu.org> writes:

> > 2004-08-25  Nathan J. Williams  <nathanw@wasabisystems.com>
> > 	* target.c (target_resize_to_sections): Check
> > 	current_target.to_sections for an old value when updating.
> 
> Can you just add some sort of brief comment noting why current_target
> also needs to be checked.  With that it's ok (but post the revised
> patch when committing).

Sure. Should I add the comment to the ChangeLog, the code, or both?
(The code already says what it's trying to do by updating all this
stuff, and while it's not obvious when something like current_target
is missing, it's pretty obvious when it's there).

        - Nathan



More information about the Gdb-patches mailing list