[rfa/dwarf/doc] Inter-compilation-unit reference support for partial DIEs

Daniel Jacobowitz drow@false.org
Sat Aug 7 22:01:00 GMT 2004


On Fri, Aug 06, 2004 at 05:22:56PM -0500, Jim Blandy wrote:
> 
> Daniel Jacobowitz <drow@false.org> writes:
> > So I can merge the two structures if you would like.  I can't think of
> > any fundamental problem.
> 
> This would also remove the special case for the stack-allocated
> compilation unit structure in dwarf2_build_psymtabs_hard, right?

No, that's a different thing entirely.  The only way to get rid of it
would be to stop stack-allocating it, and allocate/free it each time
through the loop.

The more I look at it the less inclined I am to merge dwarf2_cu and
dwarf2_per_cu_data; I'd rather find acceptable names for them.  The
dwarf2_per_cu_data is all the information we need to keep for every
compilation unit, including the not-read-in ones.  The dwarf2_cu is all
the information we need to keep around for read-in ones.  I like the
explicit separation.

The only thing weird about the list manipulation is, well, the list
pointer is only needed for read-in ones... so it went in the second
structure.

How do you feel about this?

-- 
Daniel Jacobowitz



More information about the Gdb-patches mailing list