[RFA] Prevent runaway (infinite loop) in mips-tdep.c

Michael Snyder msnyder@redhat.com
Wed Apr 21 17:58:00 GMT 2004


Daniel Jacobowitz wrote:
> On Wed, Apr 21, 2004 at 12:20:53AM +0000, Michael Snyder wrote:
> 
>>Hi Andrew,
>>
>>This change will prevent the caller(s) of mips_mdebug_frame_id from
>>infinite-looping when we get badly lost on the stack frame.
>>
> 
> 
>>2004-04-21  Michael Snyder  <msnyder@redhat.com>
>>
>>	* mips-tdep.c (mips_mdebug_frame_cache): Call error to prevent
>>	infinite looping by caller.
>>	(heuristic_proc_start): Warning() already prefixes "Warning: ".
> 
> 
> Since I have some patches to make this "I'm not sure how" case into a
> working part of the unwinder, I don't much like this.  They got hung up
> on the question of how to trust proc_desc's when we might be in the
> prologue.
> 
> One time where this case occurs is in backtracing from a NULL pointer
> dereference, which happens in the GDB testsuite now.

OK -- can I see your patches?  Maybe they'll solve the runaway condition
I'm experiencing, and if not, maybe I can fix it in a way that's
consistant with what you're doing.



More information about the Gdb-patches mailing list