[RFA/testsuite] get rid of gdb_suppress_entire_file in asm-source.exp

Joel Brobecker brobecker@gnat.com
Mon Apr 19 17:29:00 GMT 2004


I noticed that this testcase is using gdb_suppress_entire_file, and
I remember being told that this function was evil. So I suggest the
following cleanup for this gdb.asm test:

2004-04-19  Joel Brobecker  <brobecker@gnat.com>

        * gdb.asm/asm-source.exp: Remove use of gdb_suppress_entire_file.

OK to apply?

-- 
Joel
-------------- next part --------------
Index: gdb.asm/asm-source.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
retrieving revision 1.49
diff -u -p -r1.49 asm-source.exp
--- gdb.asm/asm-source.exp	31 Jan 2004 14:32:24 -0000	1.49
+++ gdb.asm/asm-source.exp	19 Apr 2004 17:24:56 -0000
@@ -115,7 +115,8 @@ switch -glob -- [istarget] {
 }
 
 if { "${asm-arch}" == "" } {
-    gdb_suppress_entire_file "Assembly source test -- not implemented for this target."
+    unsupported "Assembly source test -- not implemented for this target."
+    return -1
 }
 
 # On NetBSD/ELF we need a special NetBSD-identifying note section.


More information about the Gdb-patches mailing list