[patch/resend/rfa] (2/4) Cleanup tm-hppa.h for multiarch.
Randolph Chung
randolph@tausq.org
Thu Apr 15 16:37:00 GMT 2004
In reference to a message from Andrew Cagney, dated Apr 15:
> >2004-04-13 Randolph Chung <tausq@debian.org>
> >
> > * hppa-tdep.h (INSTRUCTION_SIZE): Move from tm-hppa.h.
> > * config/pa/tm-hppa.h (INSTRUCTION_SIZE): Move to hppa-tdep.c.
>
> It should be renamed to HPPA_INSTRUCTION_SIZE and might as well declare
> it as:
> enum { HPPA_INSTRUCTION_SIZE = 4 };
> Also does the new PA GNU/Linux file use INSTRUCTION_SIZE? If it
> doesn't, the definition might as well live in hppa-tdep.c
right now the linux file doesn't do very much, no references to
instruction size yet. I'm not quite sure there's a lot of value in using
a enum/#define vs just inlining it and putting e.g. 4*x
> After that (remember to update hppa-tdep.c's references) ok,
thanks.
randolph
--
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/
More information about the Gdb-patches
mailing list