[commit] target_open (target, ...)
Andrew Cagney
ac131313@redhat.com
Thu Oct 23 02:55:00 GMT 2003
> Wrong patch? This is target_close, not target_open. It also deletes
> the target_open macro without adding a new target_open function.
No, a 180 description. s/target_open/target_close/. The _macro_
target_open() is _never_ called.
> Please don't add 'x'. There's nothing wrong with having a target_open
> function which calls target_ops->to_open.
The vector already contains ->to_open and ->to_close methods so unless
we've switched to C++, I can't add a second to_close.
Once the existing ->to_close is deprecated, I can rename ->to_xclose.
Andrew
More information about the Gdb-patches
mailing list